Update dependent keys after a successful load#1375
Conversation
See #1156 (comment) for details
|
yes, this fixes the issue, I will think about the test today. Thank you |
|
@designatednerd here is a test that verifies it's working. I wouldn't add it as it is, because it's messy (In order to make this work I've created a new query with the same structure as If I have the time in the next week or so I will try to come up with something better because the issue we are fixing is a bit hidden and it's very easy to miss. |
…ge from the cache and once for the change from a related query.
|
@teodorpenkov Thanks for your help with the idea - I've taken the test and fleshed it out a bit, would love your feedback, but it passes when resetting the dependent keys is there and fails when it's commented out, so I think it should be an effective safety net. |
|
@teodorpenkov thanks for the inspo on the test, it already caught a massive bug with query watchers on the networking rewrite branch 🙃 |
Addresses #1365 - @teodorpenkov, can you confirm this fixes your issue? I'm still futzing around on how to test this.